Correctness statistics for DSE#1587
Open
agusaldasoro wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measureDseCorrectnessflag: after Z3 returns SAT, the generated rows are fed back throughSqlHeuristicsCalculatorto compute a distance to the original SQL predicate — logs a warning ifdistance is non-zero and records it in
StatisticsSmtLibGenerator: the old code required every PK column to differ individually across rows, which was over-constrained (e.g. it ruled out(emp=1, proj=2)and(emp=1, proj=3)as a pair). Now emits an OR assertion so only the tuple must be distinctSmtLibGeneratorto handle DELETE and UPDATE statements, not just SELECTLongValuegene mapping: was calling.toInt()and silently truncating large values; now usesLongGeneJSqlVisitorparsing improvements and newSmtLibGeneratorTestcoverageMotivation
The Z3 solver could generate rows that technically satisfy the SMT-LIB encoding but fail the original SQL predicate, due to encoding gaps (composite PKs, unsupported statement types, type
truncation). This PR adds a post-hoc verification step to detect those cases and tracks them as a metric, while also fixing the most common encoding bugs that caused them.
New Stats
dseCorrectnessChecksdseCorrectnessZeroDistancedseCorrectnessNonZerodseCorrectnessAvgDistdseCorrectnessEvalFailures